Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0.0-rc.4] Cannot create property 'colors' #375

Closed
daKmoR opened this issue Nov 29, 2018 · 4 comments · Fixed by #376
Closed

[4.0.0-rc.4] Cannot create property 'colors' #375

daKmoR opened this issue Nov 29, 2018 · 4 comments · Fixed by #376
Assignees
@matthieu-foucault
Labels
priority: 1 (critical) severity: 2 (regression) status: Approved type: Bug

Comments

@daKmoR
Copy link
Collaborator

daKmoR commented Nov 29, 2018

Using 4.0.0.-rc.4 I get an error Can not load "webpack"!

Expected Behavior

Successful compile as with 4.0.0.-rc.2
https://circleci.com/gh/open-wc/open-wc/291

Actual Behavior

with 4.0.0.-rc.4

Can not load "webpack"!
TypeError: Cannot create property 'colors' on string 'errors-only'

https://circleci.com/gh/open-wc/open-wc/290
@matthieu-foucault matthieu-foucault self-assigned this Nov 29, 2018
@matthieu-foucault
Copy link
Collaborator

Looks like a regression introduced by #356 , fixing this ASAP

@matthieu-foucault matthieu-foucault mentioned this issue Nov 29, 2018
Merged
6 tasks
@matthieu-foucault
Copy link
Collaborator

I'm pretty sure the PR above fixes it, but I can't even reproduce the bug in the first place. I tried to add 'use strict' to my karma.conf.js, but everything works for me...
@daKmoR can you test with karma-webpack@webpack-contrib/karma-webpack#fix-stringstats-color

@daKmoR
Copy link
Collaborator Author

daKmoR commented Nov 29, 2018

thx for the fast reply :) I am currently on the go but I will check it latest by tomorrow :)

not sure yet how as locally it's flaky - it fail like only 10% of the time... on circleci it fails always...
I can probably publish a temporary version somewhere and still run it through circleci...
anyways I think I will figure something out

@daKmoR
Copy link
Collaborator Author

daKmoR commented Nov 29, 2018

ok did a new install of all node_modules and had the error now locally too (also I had it now always)

the proposed fix in #376 solves it indeed 👍

matthieu-foucault added a commit that referenced this issue Nov 30, 2018
@matthieu-foucault
fix(karma-webpack): Do not unify "colors" property if webpack "stats"…
840dea2 
… is a string (#376)

Fixes a regression introduced in 9559306
Fixes #375
@matthieu-foucault matthieu-foucault mentioned this issue Nov 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthieu-foucault matthieu-foucault

Labels
priority: 1 (critical) severity: 2 (regression) status: Approved type: Bug
Projects
None yet
Milestone
No milestone
2 participants
@daKmoR @matthieu-foucault