feat(karma-webpack): unify webpack and karma color config

[spicalous]

Unifies the color config between webpack and Karma. See #332

Type

• Feature

Issues

• Fixes Karma webpack color option #332

SemVer

• Minor

[jsf-clabot]

All committers have signed the CLA.

[michael-ciniawsky]

Will this always override the default webpack colors config ? This would be a breaking change then... Could this eventually be made an option intead ? e.g

if (config.colors) {
  webpackDevMiddlewareOptions.stats.colors = colors
}

⚠️ Not sure if this works correctly, but to illustrate the idea :)

[spicalous]

@michael-ciniawsky Thanks for the response :) What do you mean by a breaking change?

It should work in a similar way that webpack's watch config is being overridden by Karma's singleRun config https://github.com/webpack-contrib/karma-webpack/blob/master/src/karma-webpack.js#L56

If you specify colors: false on Karma, you probably don't want colors on webpack's output either

[michael-ciniawsky]

I'm honstely not too familiar with in this particular area, so I might misunderstand the changes made here... My current understanding is that webpackDevMiddlewareOptions.stats.colors = colors always 'overrides' the webpack defaults (?) What are the webpack defaults? No colors at all (then everthing should be fine as-is)? Could you maybe post a screenshot before/after to clearify?

[spicalous]

Below are some images to illustrate the changes

I have a simple project setup you can play around with https://github.com/spicalous/color-example

First image: No configs (Karma and webpack output color)

Second image: Karma color:false (Karma outputs no color, webpack outpus color)

Third image: Karma color:false after changes (Karma and webpack both output no color)

[martinhorsky]

webpackMiddlewareOptions.stats could be string. This breaks configuration i.e.:

  //...
  stats: 'errors-only'

[matthieu-foucault]

Fixed in rc.5

[ryanclark]

LGTM