fix(karma-webpack): disable optimization by default (webpack >= v4.0.0)

[scottohara]

What is the current behavior? (You can also link to an open issue here)

For webpack 4, the presence of optimization.splitChunks and optimization.runtimeChunk causes karma to hang at the message 'Compiled successfully' (#322)

What is the new behavior?

A workaround is for end-users to set these two properties to false in their webpack/karma configs; however it would make more sense to have karma-webpack do this in all cases, so that new users aren't left scratching their heads as to why their test suite won't run.

Type

• Bugfix

Issues

• Fixes Karma webpack hangs on the Compiled successfully statement when wepback optimization is set #322

SemVer

• Fix (🏷 Patch)

Checklist

• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

[jsf-clabot]

All committers have signed the CLA.

[ryanclark]

@scottohara I've been working on karma being able to serve the virtual files generated by webpack, so this isn't needed as it'll support multiple chunks, etc. Let me know if you want to collaborate on it!

[scottohara]

@rynclark That's great news.

I was beginning to wonder if this project had been abandoned, as there had been little to no activity over the past month, and v4.0.0-beta.0 (required for [email protected]) was released nearly 2 months ago with no further updates since then.

So its good to hear that someone else is working on solutions for karma-webpack to play nicely with [email protected].

[edmorley]

I've been working on karma being able to serve the virtual files generated by webpack, so this isn't needed as it'll support multiple chunks, etc.

Would it be possible to merge/release this PR in the meantime? For users who haven't discovered the workaround, #322 is a complete blocker for being able to use karma-webpack with webpack 4.

[ryanclark]

Yeah I don't see why not. The update to karma-webpack has been taking longer than expected

[edmorley]

Yeah I don't see why not. The update to karma-webpack has been taking longer than expected

Gentle ping :-)

[ryanclark]

@edmorley I’m not the one who makes the decision I’m afraid 😔

[edmorley]

@michael-ciniawsky ^ :-)

[michael-ciniawsky]

First if all sry for the late response I try to keep things alive here, but this package badly needs some maintainers (actively using it) to make progress in a timely manner :)

I believe this needs to be opened against the next branch (npm i -D karma-webpack@next) instead since v4.0.0-beta.0 is the official version for webpack >= 4.0.0. We should promote it as @latest asap but as mentioned this package currently lacks maintainers, which will always cause delays like this atm :)

[scottohara]

Thanks @michael-ciniawsky. I have updated the base branch from master to next.

[michael-ciniawsky]

I'm going ahead with this along with other pending PR's and try to release a new version in the next few days, potentially including #336 && #338 (⚠️ please help to review ⚠️)

[michael-ciniawsky]

@scottohara Thx

[michael-ciniawsky]

Released in v4.0.0-rc.0 🎉