Skip to content

Commit

Permalink
fix(karma-webpack): don't include the os.tmpdir (`output.publicPath…
Browse files Browse the repository at this point in the history
…`) (#338)
  • Loading branch information
pat841 authored and michael-ciniawsky committed Sep 7, 2018
1 parent 2145ec2 commit 66f4cd7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/karma-webpack.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ function Plugin(
'/'
);
webpackOptions.output.publicPath = path.join(
os.tmpdir(),
'/',
'_karma_webpack_',
publicPath,
'/'
Expand Down Expand Up @@ -211,7 +211,7 @@ function Plugin(
compiler.hooks.invalid.tap(this.plugin, invalid.bind(this));

webpackMiddlewareOptions.publicPath = path.join(
os.tmpdir(),
'/',
'_karma_webpack_',
'/'
);
Expand Down

1 comment on commit 66f4cd7

@gfdickinson
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the change that you made, we don't want to use path.join right? It will convert the '/' into '' in a windows env right?

Please sign in to comment.