Skip to content
This repository has been archived by the owner on Aug 20, 2018. It is now read-only.

False positive warning about Webpack 2 #57

Closed
gaearon opened this issue Jul 22, 2017 · 5 comments · Fixed by #58
Closed

False positive warning about Webpack 2 #57

gaearon opened this issue Jul 22, 2017 · 5 comments · Fixed by #58

Comments

@gaearon
Copy link

gaearon commented Jul 22, 2017

We are seeing this warning on CI trying to update Create React App to Webpack 3: facebook/create-react-app#2574 (comment). However we never explicitly use json-loader.

I wonder if it's possible that the warning has a false positive? For example webpack/webpack#3374 makes webpack delegate to json-loader automatically here. Is there any chance that this could unintentionally trigger the warning?

@albertsaave
Copy link

+1

@scotmatson
Copy link

I noticed this issue when I have placed some dependencies for package.json under devDependencies. I have since moved everything back under dev and the warnings no longer occur.

@joshwiens
Copy link
Member

@gaearon - I've stripped the deprecation warning entirely, this is a problem that needs to be fixed upstream as the whole thing is kind of circular.

[email protected]

@gaearon
Copy link
Author

gaearon commented Jul 22, 2017

Thanks!

@ollivierv
Copy link

Thank you @d3viant0ne ! With the "json-loader": "^0.5.7" in the package.json, we get rid of thoses "useless" warning messages ! 🥇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants