Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

test: fix && update flaky snapshots #66

Merged
merged 1 commit into from
Jul 11, 2017
Merged

test: fix && update flaky snapshots #66

merged 1 commit into from
Jul 11, 2017

Conversation

mattlewis92
Copy link
Member

@mattlewis92 mattlewis92 commented Jul 10, 2017 •
edited
Loading

Notable changes:

  • removed the webpack manifest from snapshots to remove noise
  • wrapped the loader with a hack to force the resourcePath to be consistent across builds so the instrumented output is always the same

@mattlewis92 mattlewis92 force-pushed the extract-manifest branch 2 times, most recently from 829793b to aedc424 Compare July 10, 2017 09:13
@codecov-io
Copy link

codecov-io commented Jul 10, 2017 •
edited by codecov bot
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@5a1c4e8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #66   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      2           
  Lines             ?      6           
  Branches          ?      0           
=======================================
  Hits              ?      6           
  Misses            ?      0           
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1c4e8...cec1986. Read the comment docs.

@mattlewis92 mattlewis92 changed the title WIP: fix tests on master Fix tests on master Jul 10, 2017
@mattlewis92 mattlewis92 reopened this Jul 10, 2017
michael-ciniawsky
michael-ciniawsky suggested changes Jul 10, 2017
View reviewed changes
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 These are very valueable changes you made so far, especially regarding the test setup. Thx in advance :)

test/webpack.js
@@ -19,6 +19,11 @@ export default function ({ fixture = 'basic.js', options, extend = {} } = {}) {
}],
},
...extend,
plugins: [
new webpack.optimize.CommonsChunkPlugin({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this split the webpack runtime from the test bundle ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, you can see the change in the snapshot diff, its much cleaner 😄

test/wrap-loader.js Outdated
@@ -0,0 +1,10 @@
import loader from '../src/cjs';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Put wrap-loader.js && webpack.js into a e.g utils folder and rename wrap-loader => loader.js please

|– test
| |– __snapshots__
| |– index.test.js
| |– ${option.name}.test.js
| |– ...
| |– utils
| | |– webpack.js (Compiler/Runner)
| | |– stats.js (Generic Stats/Compilation Normalizer [ TODO ])
| | |– loader.js (Generic Loader Normalizer)

Sry to bother you with this all the time, it's drafting out the base test system on the job :D

@michael-ciniawsky michael-ciniawsky changed the title Fix tests on master test: fix && update flanky snapshots Jul 10, 2017
@michael-ciniawsky michael-ciniawsky changed the title test: fix && update flanky snapshots test: fix && update flaky snapshots Jul 10, 2017
@mattlewis92
Copy link
Member Author

@michael-ciniawsky done!

@joshwiens
Copy link
Member

Ship it @michael-ciniawsky

@mattlewis92 mattlewis92 mentioned this pull request Jul 10, 2017
Merged
@joshwiens joshwiens merged commit d0cf823 into webpack-contrib:master Jul 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshwiens joshwiens joshwiens approved these changes

@michael-ciniawsky michael-ciniawsky michael-ciniawsky approved these changes

Assignees
No one assigned
Labels
semver: Patch status: Approved type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattlewis92 @codecov-io @joshwiens @michael-ciniawsky