-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seems to add extra packages to package.json #26
Comments
Weird. I do a check to ignore any sub-modules that are in
|
Also seemed to install |
Different directory? Which directory is it? You have a |
@ericclemmons The modules folder was specified using the resolveLoader.root option of webpack (both the dependencies are for the server and they were missing). The actual project is in a different directory. |
Trying to integrate with - https://github.com/satya164/quik , which is a server to do dev without setup. |
Ah, now I see. Yep, this is a problem until #17 is finished up. I'm launching a project this week, so I should be able to finalize the next release soon. Sorry for the delay! |
@ericclemmons Ah. Cool. Thanks :) |
@satya164 Wanna check this out with v3.0.0? |
@ericclemmons Will do soon. Thank you. |
Re-open if it's an issue! |
Super cool idea, by the way. But I'm trying it out and it seems like it's adding the dependencies of my dependencies to package.json. For instance,
cheerio
is a dependency ofenzyme
, and I'm using enzyme in my app. Butnpm-install-webpack-plugin
installed cheerio into my package.json even though I'm not relying on it directly.The text was updated successfully, but these errors were encountered: