Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems to add extra packages to package.json #26

Closed
bmakuh opened this issue Feb 4, 2016 · 10 comments
Closed

Seems to add extra packages to package.json #26

bmakuh opened this issue Feb 4, 2016 · 10 comments

Comments

@bmakuh
Copy link

bmakuh commented Feb 4, 2016

Super cool idea, by the way. But I'm trying it out and it seems like it's adding the dependencies of my dependencies to package.json. For instance, cheerio is a dependency of enzyme, and I'm using enzyme in my app. But npm-install-webpack-plugin installed cheerio into my package.json even though I'm not relying on it directly.

@ericclemmons
Copy link
Member

Weird. I do a check to ignore any sub-modules that are in node_modules.

  • Test dependency installation of cheerio.

@satya164
Copy link

satya164 commented Feb 9, 2016

Also seemed to install babel-loader as well as webpack-hot-middleware into my project. They are dependencies of a server located in a different directory.

@ericclemmons
Copy link
Member

Different directory? Which directory is it? You have a package.json in
your project right?

@satya164
Copy link

satya164 commented Feb 9, 2016

@ericclemmons The modules folder was specified using the resolveLoader.root option of webpack (both the dependencies are for the server and they were missing). The actual project is in a different directory.

@satya164
Copy link

satya164 commented Feb 9, 2016

Trying to integrate with - https://github.com/satya164/quik , which is a server to do dev without setup.

@ericclemmons
Copy link
Member

Ah, now I see. Yep, this is a problem until #17 is finished up. I'm launching a project this week, so I should be able to finalize the next release soon.

Sorry for the delay!

@satya164
Copy link

@ericclemmons Ah. Cool. Thanks :)

@ericclemmons
Copy link
Member

@satya164 Wanna check this out with v3.0.0?

@satya164
Copy link

satya164 commented Mar 8, 2016

@ericclemmons Will do soon. Thank you.

@ericclemmons
Copy link
Member

Re-open if it's an issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants