Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importLoaders option descriptions contradictory? #510

Closed
ndresx opened this issue Apr 23, 2017 · 2 comments
Closed

importLoaders option descriptions contradictory? #510

ndresx opened this issue Apr 23, 2017 · 2 comments
Assignees

Comments

@ndresx
Copy link
Contributor

ndresx commented Apr 23, 2017

Do you want to request a feature or report a bug?
documentation

What is the current behavior?
Under Options (https://github.com/webpack-contrib/css-loader#options), the description for importLoaders mentions before ...

Number of loaders applied before CSS loader

... while under the importLoaders section (https://github.com/webpack-contrib/css-loader#importloaders) it says used after

That many loaders after the css-loader are used to import resources.

What is the expected behavior?
It should be either before, or after, or not? Maybe it needs some commas too, but honestly, it sounds a bit confusing to me.

As far as I am understanding this, if for example sass-loader and postcss-loader are used before the css-loader, importLoaders could be set to 2 to make use of both loaders when using @import, but also to 1 if it should only use the sass-loader?

@michael-ciniawsky
Copy link
Member

Yep the spelling could be improved, PR welcome 😛

As far as I am understanding this, if for example sass-loader and postcss-loader are used before the css-loader, importLoaders could be set to 2 to make use of both loaders when using @import, but also to 1 if it should only use the sass-loader?

👍

@michael-ciniawsky
Copy link
Member

Fixed by #512 @ndresx Thx again 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants