Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add module.type option, the icss option is deprecated #1150

Merged
merged 4 commits into from
Jul 31, 2020

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fixes #1134

Breaking Changes

No

Additional Info

The icss option is deprecated

@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #1150 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1150   +/-   ##
=======================================
  Coverage   99.34%   99.35%           
=======================================
  Files          10       10           
  Lines         614      618    +4     
  Branches      190      193    +3     
=======================================
+ Hits          610      614    +4     
  Misses          4        4           
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)
src/utils.js 98.43% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9070ba9...c0a62ca. Read the comment docs.

@alexander-akait alexander-akait merged commit 68f72af into master Jul 31, 2020
@alexander-akait alexander-akait deleted the issue-1134 branch July 31, 2020 15:15
@jquense
Copy link
Contributor

jquense commented Jul 31, 2020

awesome, as always thanks for all the hard work 👍

@soulofmischief
Copy link

soulofmischief commented Aug 2, 2020

@evilebottnawi using css-loader without any options now swallows :export directives for me. It seems I can specify 'icss' but then I would lose full module support. Not even sure if that would fix it anyway. I can open a bug report if need be.

@alexander-akait
Copy link
Member Author

@soulofmischief open an new issue with reproducible test repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4 breaks css-module-loader
3 participants