fix(src/): don't escape non-glob patterns #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was harder to test than I thought because of #220 😅 Still, I can confirm that this PR fixes the referenced issue. I also tested watching a directory and a simple glob and both work fine on Windows. 👍 |
michael-ciniawsky
changed the title
|
@michael-ciniawsky we need |
michael-ciniawsky
added
status: Approved
and removed
pr_action: Review
priority: 4 (important)
severity: 2 (regression)
labels
|
Released in |
This was referenced Feb 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IssuesNo tests, because we should catch this in window CI, but CI don't have this right now 😞