This repository has been archived by the owner on Oct 27, 2020. It is now read-only.
Drop support for node < 6 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
=======================================
Coverage 17.14% 17.14%
=======================================
Files 2 2
Lines 105 105
Branches 15 15
=======================================
Hits 18 18
Misses 73 73
Partials 14 14Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
=======================================
Coverage 17.14% 17.14%
=======================================
Files 2 2
Lines 105 105
Branches 15 15
=======================================
Hits 18 18
Misses 73 73
Partials 14 14Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Dec 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other loaders @1.x on webpack (like css-loader for example) don't support a node version < 6.9.0.
We should do the same as the other lower node versions are really old and not updated anymore with security patches (end of life for 4.x was April 2018).
This PR drops the support node versions < 6.9.0.
\CC @evilebottnawi