New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why not throw an Error when script onerror? #45

Open

llyo opened this issue May 17, 2018 · 0 comments

llyo commented May 17, 2018 •

edited

Loading

when script error, throw an error in advance instead of waitting the callback in timer

script = document.createElement('script');
script.src = url;
// add onerror
script.onerror = function() {
    cleanup();
    if (fn) fn(new Error('Failure'));
}
target.parentNode.insertBefore(script, target);

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment