Headless CMS - Ensure Published Entries Are Fully Deleted #4265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrians5j
changed the title
esEntity instead of entity
adrians5j
changed the title
adrians5j
changed the title
adrians5j
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR resolves an issue where deleting a published revision of a content entry would not make the revision disappear when accessing data via Headless CMS's READ GraphQL API.
This was happening because of a mistake in the deletion process' code. In the code, upon trying to delete the "published" record from DDB -> ES table, we were mistakenly using primary DynamoDB table's
entityobject, instead of DDB -> ES'sesEntityobject.How Has This Been Tested?
Added a Jest test.
Documentation
Changelog.