Fix/fixing windows 11 build #4182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@will-fagerstrom thanks, I triggered tests to see if everything is 🟢 |
adrians5j
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Looks good, let's have this for 5.40.2, just so we have some time to potentially catch undiscovered issues with the lib update.
Thanks @will-fagerstrom! 🍻 🍻 🍻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Builds on windows 11 dev drive fail for two reasons.
rimrafglobing is not on by default in version 5fs-extraout of date not working with windows 11's dev-drive ReFS file systemCloses #4181
How Has This Been Tested?
yarn buildsuccessfully completes.Documentation
Should ne no change to any user or developer