fix(api-headless-cms-tasks): race conditions while emptying the entries #4144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunozoric
approved these changes
May 22, 2024
leopuleo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With this PR, we aim to:
TaskCacheandTaskTriggerThe main change introduced by this fix is the use of a cache to store all the subtasks created while looping through the entries that need to be deleted.
Previously, when dealing with a large number of entries, the child tasks would start executing while the main task was still executing. This could cause a race condition and lead to failures when deleting some entries that had already been deleted by other subtasks.
With this pull request, we are now storing inputs for subtasks inside an internal cache and executing them after the main task loop finishes.
How Has This Been Tested?
Manually + Jest