Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-trash-bin): various fixes and improvements #4088

Merged
merged 16 commits into from
Apr 24, 2024

Conversation

leopuleo
Copy link
Contributor

@leopuleo leopuleo commented Apr 18, 2024

Changes

With this PR, we fix some bugs found while using the trash bin:

  • Add audit logs statuses related to trash bin actions: MOVE TO TRASH + RESTORED FROM TRASH.
  • Support callback when the item is restored from the trash bin, such as fetching the entry from the API and adding it to the list.
  • Add the getRestoredItemById presenter method to show the item location link when the item is restored.
  • Remove the cursor: pointer from the item title.
  • Change the message shown when permanently deleting an item.
  • Show different messages when the list is empty after a user search.
  • Add support for the WEBINY_ADMIN_TRASH_BIN_RETENTION_PERIOD_DAYS env variable to show the entry retention period in days.

How Has This Been Tested?

Manually + Jest

@leopuleo leopuleo added this to the 5.40.0 milestone Apr 18, 2024
@leopuleo leopuleo self-assigned this Apr 18, 2024
Copy link
Collaborator

@Pavel910 Pavel910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename onAfterItemRestore to onItemAfterRestore, like we have in all API events.

@leopuleo leopuleo merged commit cafef9a into next Apr 24, 2024
90 checks passed
@leopuleo leopuleo deleted the leo/fix/hcms-trash-bin-admin branch June 5, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants