Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why? #4

Open
janopae opened this issue Sep 5, 2023 · 3 comments
Open

Why? #4

janopae opened this issue Sep 5, 2023 · 3 comments

Comments

@janopae
Copy link
Member

janopae commented Sep 5, 2023

What are the benefits of running Psalm, along with extensions, in a Docker image, instead of declaring it as a dev dependency of the application we analyse with Psalm (like the documentation proposes)?

@janopae
Copy link
Member Author

janopae commented Dec 12, 2023

Some disadvantages of the Docker approach are

@tedsalmon
Copy link

For me, I don't have PHP installed outside of Docker because my workflows require multiple versions of PHP to be available for different projects.

@janopae
Copy link
Member Author

janopae commented Dec 22, 2023

For me, I don't have PHP installed outside of Docker because my workflows require multiple versions of PHP to be available for different projects.

Wouldn't multiple PHP versions actually be a reason against having psalm strictly attached to one PHP version in a Docker image seperate to the ones you use for other PHP commands? How do you ensure the PHP version in the Psalm docker image is among the ones you want to support?

You could use the same Docker image that you use for all of your other PHP related commands in that project for executing Psalm.

I still don't get the benefit of having psalm installed in that image with a custom PHP version and a fixed set of plugins, rather than using the version installed with composer with the PHP interpreter(s) you use for everything else.

CC @mpdude

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants