Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate shortcode service configurations (Case 173693) #35

Open
MalteWunsch opened this issue Jul 24, 2024 · 0 comments · May be fixed by #40
Open

Validate shortcode service configurations (Case 173693) #35

MalteWunsch opened this issue Jul 24, 2024 · 0 comments · May be fixed by #40

Comments

@MalteWunsch
Copy link
Member

I've screwed up a shortcode configuration by passing a positional parameter to the EmbeddedShortcodeHandler like this:

    webfactory.shortcode.x:
        parent: 'webfactory.shortcode.embed_inline_for_shortcode_handler'
        class: 'Webfactory\ShortcodeBundle\Handler\EmbeddedShortcodeHandler'
        arguments:
            - 'My\ShortcodeController::myAction'
        tags: [...]

which should have been a named parameter:

        arguments:
            $controllerName: 'EuroInformationen\Bundle\KrankenkassenBundle\Wechselservice\ShortcodeController::linkZuWechselFormularAction'

I wish we would throw an exception in this case (and similar cases).

@MalteWunsch MalteWunsch changed the title Validate shortcode service configurations Validate shortcode service configurations (Case 173693) Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant