-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(WebexMeetings): update member name from join prompt #240
Conversation
WalkthroughThe changes in this pull request involve updates to the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🔇 Additional comments (1)package.json (1)
The patch version increments for both Let's verify the version compatibility and changelog entries: ✅ Verification successfulAll dependency versions are verified and compatible. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify version compatibility and changelog entries for the updated dependencies
# Check if the versions exist in npm registry
echo "Checking @webex/[email protected]..."
npm view @webex/[email protected] version
echo "Checking @webex/[email protected]..."
npm view @webex/[email protected] version
# Fetch the latest versions for comparison
echo "Latest versions:"
npm view @webex/sdk-component-adapter version
npm view @webex/components version
# Check for any peer dependency conflicts
npm info "@webex/[email protected]" peerDependencies
npm info "@webex/[email protected]" peerDependencies
Length of output: 737 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🎉 This PR is included in version 1.27.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes SPARK-552246
This pull request addresses
This PR enhances the getMembers function by including the
name
property in the returned member objects. By adding thename: member.name
, each member object now contains the participant's display name in a local sample app of widgets, improving the comprehensiveness of the member data. If the user wanted to pass thename
according to there wish that will be appear on widgets sample app (or) the system default name will be displayedRecording
sdk-component.recording.mp4
Note:
This is just a version update PR for the following changes:
Tested with this PR changes and here's a screenshot
Summary by CodeRabbit