Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WebexMeetings): update member name from join prompt #240

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

mkesavan13
Copy link
Contributor

@mkesavan13 mkesavan13 commented Nov 13, 2024

Closes SPARK-552246

This pull request addresses

This PR enhances the getMembers function by including the name property in the returned member objects. By adding the name: member.name, each member object now contains the participant's display name in a local sample app of widgets, improving the comprehensiveness of the member data. If the user wanted to pass the name according to there wish that will be appear on widgets sample app (or) the system default name will be displayed

Recording

sdk-component.recording.mp4

Note:

This is just a version update PR for the following changes:

  1. SDK Component Adapter: fix(MembershipsSdkAdapter): added name property to member mapping in getmembers function sdk-component-adapter#344
  2. Components: fix(webexMember): updated member name handling components#845

Tested with this PR changes and here's a screenshot

Screenshot 2024-11-13 at 8 27 08 PM

Summary by CodeRabbit

  • Chores
    • Updated dependency versions for improved performance and stability.

Copy link

coderabbitai bot commented Nov 13, 2024

Walkthrough

The changes in this pull request involve updates to the package.json file for the @webex/widgets project. Specifically, the versions of two dependencies have been incremented: @webex/sdk-component-adapter from 1.112.12 to 1.112.13 and @webex/components from 1.275.2 to 1.275.3. No other modifications were made to the file's structure or content.

Changes

File Change Summary
package.json Updated @webex/sdk-component-adapter from 1.112.12 to 1.112.13, updated @webex/components from 1.275.2 to 1.275.3.

Poem

In the garden of code, I hop with glee,
Versions updated, as fresh as can be!
With adapters and components, we dance and play,
New numbers in place, brightening the day.
A leap for the widgets, a joyful surprise,
Let’s celebrate changes beneath the blue skies! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between e7ddee7 and 7ebae92.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json (1 hunks)
🔇 Additional comments (1)
package.json (1)

35-37: LGTM! Version updates align with PR objectives.

The patch version increments for both @webex/sdk-component-adapter and @webex/components are consistent with the PR's goal of updating member name functionality from join prompt.

Let's verify the version compatibility and changelog entries:

✅ Verification successful

All dependency versions are verified and compatible.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify version compatibility and changelog entries for the updated dependencies

# Check if the versions exist in npm registry
echo "Checking @webex/[email protected]..."
npm view @webex/[email protected] version

echo "Checking @webex/[email protected]..."
npm view @webex/[email protected] version

# Fetch the latest versions for comparison
echo "Latest versions:"
npm view @webex/sdk-component-adapter version
npm view @webex/components version

# Check for any peer dependency conflicts
npm info "@webex/[email protected]" peerDependencies
npm info "@webex/[email protected]" peerDependencies

Length of output: 737


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mkesavan13 mkesavan13 merged commit a6c5298 into webex:master Nov 13, 2024
2 checks passed
@sreenara
Copy link
Contributor

🎉 This PR is included in version 1.27.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants