Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meetings): added reachability trigger to metrics #3850

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

marcin-bazyl
Copy link
Collaborator

COMPLETES #SPARK-562699

This pull request addresses

We've recently added information about timings for IP network version checks to "js_sdk_reachability_completed" metric, but reachability is triggered from various places, one of them being reconnection. We want to know the timings just from reachability that's called during webex.meetings.register() and not from reconnection.

by making the following changes

added reachability trigger information to the "js_sdk_reachability_completed" metric

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

unit tests

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@marcin-bazyl marcin-bazyl requested review from a team as code owners September 20, 2024 11:43
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3850.d3m3l2kee0btzx.amplifyapp.com

@marcin-bazyl marcin-bazyl added the validated If the pull request is validated for automation. label Sep 20, 2024
@marcin-bazyl marcin-bazyl merged commit b93ddef into webex:next Sep 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated for automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants