Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add github no reply email detection #88

Conversation

alcpereira
Copy link
Contributor

@alcpereira alcpereira commented Sep 1, 2024

Solves #86

This PR contains 3 commits:

  • A small removal of the hardcoded Github token, while they are already invalid credentials, it may attract unwanted attention from token crawlers
  • The feature itself:
    • Added a bit of breathing space to the original Github comment (thus updating the snapshot)
    • Logic, new comment, and tests for the new detection feature
  • Build of the dist folder (includes changes from fix: tailwind react-email unique key prop issue #87 )

I'm not very familiar with Vitest mocking, but I had to add a createComment.mockClear(), let me know if I should avoid it.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👌

@christian-bromann christian-bromann merged commit 7d94908 into webdriverio:main Sep 1, 2024
3 checks passed
@wdio-bot
Copy link

wdio-bot commented Sep 1, 2024

Hey alcpereira 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at [email protected] or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

@alcpereira alcpereira deleted the feat/add-gh-no-reply-email-detection branch September 1, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants