Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix how custom element declarations extend class declarations #73

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Fix how custom element declarations extend class declarations #73

merged 1 commit into from
Jul 1, 2021

Conversation

justinfagnani
Copy link
Collaborator

@justinfagnani justinfagnani commented Jun 30, 2021 •
edited
Loading

Fixed how custom element declarations extend class declarations.

Previously CustomElementDeclaration didn't include CustomElement properties, and MixinDeclaration required some CustomElement properties. The fixes are:

  • Make CustomElementDeclaration extend CustomElement
  • Make MixinDeclaration extend ClassLike instead of CustomElement
  • Add new CustomElementMixinDeclaration interface that does extend CustomElement and add it to the Declaration union type.

Fixes #69

@justinfagnani justinfagnani requested a review from thepassle June 30, 2021 16:38
@thepassle
Copy link
Collaborator

LGTM, I dont seem to be able to actually merge this PR, I can only approve it

@justinfagnani justinfagnani merged commit 2d8d519 into master Jul 1, 2021
@justinfagnani justinfagnani deleted the custom-element-declaration branch July 1, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thepassle thepassle thepassle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript error: "tagName" does not exist in type 'ClassDeclaration'
2 participants
@justinfagnani @thepassle