Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schema to include CustomElementDeclaration and CustomElementMixinDeclaration #103

Merged
merged 7 commits into from
Feb 18, 2022
Merged

Fix schema to include CustomElementDeclaration and CustomElementMixinDeclaration #103

merged 7 commits into from
Feb 18, 2022

Conversation

justinfagnani
Copy link
Collaborator

@justinfagnani justinfagnani commented Feb 13, 2022 •
edited
Loading

Fixes #100

  • Checks in schema.json so we can review changes to it directly
  • Adds GitHub action to ensure schema.json is built
  • Adds an example to /examples
  • Changes CustomElementDeclaration and CustomElementMixinDeclaration to interfaces so they generate named schemas
  • Adds a test of the example schema

I recommend reviewing each commit separately.

sonntag-philipp
sonntag-philipp suggested changes Feb 13, 2022
View reviewed changes
Copy link

@sonntag-philipp sonntag-philipp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR already looks a lot better, thank you!

Sorry for my harsh words on the manifest issue :)

EDIT: Hope my feedback is appreciated, just want to help improving this manifest :)

examples/simple-element.json Show resolved Hide resolved
schema.d.ts Show resolved Hide resolved
schema.d.ts Show resolved Hide resolved
src/test/schema_test.ts Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
@justinfagnani
Copy link
Collaborator Author

Thanks for the review @sonntag-philipp !

rictic
rictic approved these changes Feb 17, 2022
View reviewed changes
.github/workflows/tests.yaml Show resolved Hide resolved
schema.d.ts Show resolved Hide resolved
src/test/schema_test.ts Outdated Show resolved Hide resolved
src/test/schema_test.ts Show resolved Hide resolved
@justinfagnani
Use interfaces to schemas appear in output
be07228 
Changes CustomElementDeclaration and CustomElementMixinDeclaration from intersection types to interfaces.
@justinfagnani
Format
b60cc62
@justinfagnani justinfagnani force-pushed the fix-schema branch 2 times, most recently from 7fae094 to a602a60 Compare February 18, 2022 01:51
@justinfagnani justinfagnani merged commit f51d149 into main Feb 18, 2022
@justinfagnani justinfagnani deleted the fix-schema branch February 18, 2022 02:19
@sonntag-philipp
Copy link

Is it possible to publish the changes to npm? @justinfagnani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonntag-philipp sonntag-philipp sonntag-philipp requested changes

@thepassle thepassle thepassle approved these changes

@rictic rictic rictic approved these changes

Assignees

@rictic rictic

@justinfagnani justinfagnani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generated schema contains errors
4 participants
@justinfagnani @sonntag-philipp @rictic @thepassle