Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reflect to property or attribute #36

Closed
bennypowers opened this issue Dec 19, 2020 · 1 comment · Fixed by #75
Closed

add reflect to property or attribute #36

bennypowers opened this issue Dec 19, 2020 · 1 comment · Fixed by #75

Comments

@bennypowers
Copy link
Contributor

There should be a way to signal whether or not a property reflects to it's associated attribute when set

@justinfagnani
Copy link
Collaborator

I think to do this the way we've done other features where a custom element adds interface on top of classes we should introduce a CustomElementField that extends a ClassField:

interface CustomElementClassField extends ClassField {
 attribute?: string;
 reflects?: boolean;
}

Then change CustomElement to override members:

  members?: Array<CustomElementMember>;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants