-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
www.mountainmikespizza.com - design is broken #106690
Comments
This is also tracked at rdar://91595821 .dialog-safari {
position: fixed !important;
top: 50% !important;
-ms-transform: translateY(-50%) !important;
transform: translateY(-50%) !important;
} Firefox Nightly 103 receives the The source of this specific hack is in function registerDialogs() {
dialogs = document.getElementsByTagName("dialog");
let browserName = GetBrowserName();
for (let i = 0; i < dialogs.length; i++) {
dialogPolyfill.registerDialog(dialogs[i]);
if (browserName === "Safari" || browserName === "Firefox") {
dialogs[i].classList.add("dialog-safari");
}
}
} The behavior of Safari is on the other hand correct, and Firefox will probably align with it. Gecko filed this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1772305 , @emilio from Mozilla suggests that Chrome/WebKit behavior might actually be correct. |
Contacts have been initiated with the people of Adora, but for now, no answers. This affects a lot of other sites.
All Adora framework. |
Once Gecko is fixing the bug, this will break on Firefox too. |
It might require a site patch. |
The offending code is still there.
This is not fixed at least on mountainmikespizza.com Probably it depends on the sites also updating their local scripts. |
@ksy36 @denschub And now Firefox should be broken too. Safari is creating a UA override for https://www.mountainmikespizza.com/ |
URL: https://www.mountainmikespizza.com
Browser / Version: Safari 16.0
Operating System: Mac OS X 10.15.7
Tested Another Browser: Yes Firefox
Problem type: Design is broken
Description: Items not fully visible
Steps to Reproduce:
Expected:
fully visible panel of choice
Actual:
The panel is hidden at the top.
View the screenshot
Browser Configuration
From webcompat.com with ❤️
The text was updated successfully, but these errors were encountered: