Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported <sys/types.h> #864

Conversation

alladinian
Copy link

Summary of Changes

Addresses an issue where builds initiated from Xcode 16 produced errors because of a missing import.

Fixes # 1 (a header import)

By submitting this pull request, you are confirming the following:
  • I have reviewed the Contribution Guidelines.
  • I have performed a self-review of my own code.
  • I have updated my repository to match the develop branch.
  • I have included test data or screenshots that prove my fix is effective or that my feature works.
  • I have checked that all tests work and swiftlint is not throwing any errors/warnings.

@JeneaVranceanu
Copy link
Collaborator

Hello @alladinian
Thanks for the fix! Could you share the original error you had and how did you get to the final solution? That would help merge this faster.

@alladinian
Copy link
Author

Hi there.
Actually there is already an open issue (#861 ) describing it.
This happens when compiling with Xcode 16 and it was due to a missing header import (no idea why this worked on previous builds - maybe a build setting changed in the new version).

@JeneaVranceanu
Copy link
Collaborator

Got it, thanks for the link! Approved for CI run.

@JeneaVranceanu
Copy link
Collaborator

Okay, I'll need to update CI to exclude spellchecks in ./Sources/secp256k1

@yaroslavyaroslav
Copy link
Collaborator

@JeneaVranceanu seems like ci/cd pipeline is still broken. Maybe we should consider to loose typo checking or to disable it completely for a while?

@AnderGoig
Copy link

Any updates on this? 🙏

@yaroslavyaroslav
Copy link
Collaborator

yaroslavyaroslav commented Sep 27, 2024

I'm merging it's blindly, so hoping it don't brakes anything for Xcode 15.* folks.

UPD: y'all still have to point to master as for dependency rather than to a particular version, as I'm incapable so far to release one

@yaroslavyaroslav yaroslavyaroslav merged commit 912fb85 into web3swift-team:master Sep 27, 2024
1 check failed
@Martin-max-art
Copy link

Cocopods Unable to find version 3.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants