-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4nodes quorum-example ? #27
Comments
blocks 131 - ... = TPS maxing out because of too low gasLimit blocks 191 - ... = only 1 validator keeps sealing txs because of too small txpool
all 20k transactions are arriving, but at peak 175 TPS (because of gasLimit), and much slower in the end (because of too small mempool). Please help, thanks. |
Thanks for your feedback. Currently, we are downloading the image from the registry, you can change Docker compose file following this line. It will build the image all over with your changes. You can then build and run the image with |
perfect, and thanks a lot for getting back to me so quickly! what about adding a My changes are here: drandreaskrueger@74e4687 |
Actually, it does not look as if it has rebuild anything:
|
Has this line been commented and the 3 lines following this been uncommented? |
ah sorry, had not see that comment/uncomment comment. Sorry. Now done like this:
correct? |
results in:
|
You will have to uncomment this and the next line. Thanks for suggesting a rebuild-docker.sh. We could work on it, if it makes it simpler. Docker compose file should look like
|
thanks a lot, that seem to have worked:
I suppose the warnings and 'loadinternal: cannot find...' I can simply ignore? |
Yea those warnings can be ignored. |
thanks.
New suggestion: With https://github.com/drandreaskrueger/crux/blob/master/docker/quorum-crux/docker-compose-local.yaml -->
however, that docker-compose-local.yaml is a full copy of docker-compose.yaml with those 4 small changes only; redundancy <-- would be better if one docker-compose_....yaml imported another one; not sure whether that's possible. |
benchmarked: click here for more details: https://gitlab.com/electronDLT/chainhammer/blob/master/quorum-IBFT.md#crux-docker-4nodes open question: is the higher speed (270 TPS instead of 200 TPS) because of docker, or because 4 not 7 nodes? --> is there perhaps a simple way to start your 7nodes crux quorum-example but with only 4 nodes, so that I could see the difference with only 1 aspect changed? (edit: shall I rather make this into a new issue? ) |
You could make changes to 3 files -
These are the changes I could think of on top of my mind. You could test it, else we could check what more changes would be necessary. |
oh fantastic, thanks. Can try that next week.
perhaps this needs edits too, no? where are the authorities defined? the remaining 3 nodes should not be waiting for 6 nodes but now only for 3 other nodes, right? |
Ah sorry, yes even the last 3 lines of https://github.com/blk-io/quorum-examples/blob/master/examples/7nodes/permissioned-nodes.json should be removed! |
Great, thanks. I followed each step, but so far could not get it working. See attachment: |
Explanation why attachment: I could not fork blk-io/quorum-examples because I have already forked jpmorganchase/quorum-examples (into here and made changes), and github allows only 1 fork. So instead I cloned your (And of course - long term please have But for now, please try to get the There is a Thanks a lot! |
[ old title was: "docker compose command after parameter changes?" ]
Thx a lot for your dockerized version, perhaps that helps us to get to higher rates than the ~200 TPS that I have been seeing in my recent benchmarks.
However, I am only seeing ~175 TPS for now, because in your setup
(a) the gasLimit is too low, see chainhammer quorum-IBFT.md #higher-gas-limit, and
(b) the txpool is too small, see chainhammer quorum-IBFT.md #mempool-settings
In the comment below you'll see the effects of those 2 too small parameters, when running your crux docker compose ...
? -->
What exactly do I have to do, after changing istanbul-genesis.json#L17 and in istanbul-start.sh#L11 ...
... by which exact command do I replace the docker-compose command from there? Thanks.
The text was updated successfully, but these errors were encountered: