constants should be before (dynamic) string contents, fix #84 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethers
added a commit
to ethers/dapp-bin
that referenced
this pull request
Feb 27, 2015
ethers
changed the title
debris
added a commit
that referenced
this pull request
Feb 28, 2015
constants should be before (dynamic) string contents, fix #84
debris
added a commit
that referenced
this pull request
Mar 3, 2015
constants should be before (dynamic) string contents, fix #84
Closed
ethers
added a commit
to ethereum/btcrelay
that referenced
this pull request
Jun 12, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #84
2 tests added. also verified by a test dapp I have that previously did not work with (string,int), and with this PR dapp works in both (int,string) and (string,int).
I can also submit another commit that renamed toAppendArrayContent with something like toAppendDynamicContent