-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Intermediate dApp Guide #7349
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: a339ac5 | Previous: 3687070 | Ratio |
---|---|---|---|
processingTx |
22802 ops/sec (±6.76% ) |
22856 ops/sec (±6.62% ) |
1.00 |
processingContractDeploy |
40163 ops/sec (±7.66% ) |
37573 ops/sec (±8.57% ) |
0.94 |
processingContractMethodSend |
16807 ops/sec (±7.21% ) |
15453 ops/sec (±7.92% ) |
0.92 |
processingContractMethodCall |
28016 ops/sec (±7.30% ) |
27091 ops/sec (±7.83% ) |
0.97 |
abiEncode |
44220 ops/sec (±7.58% ) |
42669 ops/sec (±7.08% ) |
0.96 |
abiDecode |
31246 ops/sec (±6.60% ) |
30350 ops/sec (±6.23% ) |
0.97 |
sign |
1556 ops/sec (±0.96% ) |
1520 ops/sec (±3.42% ) |
0.98 |
verify |
368 ops/sec (±0.67% ) |
362 ops/sec (±0.69% ) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7349 +/- ##
=======================================
Coverage 94.50% 94.50%
=======================================
Files 217 217
Lines 8487 8487
Branches 2343 2343
=======================================
Hits 8021 8021
Misses 466 466
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for backward compatibility these types are also available under namespace https://github.com/web3/web3.js/pull/7333/files#diff-d4266516ea1f07f253f5ea9980ce3225d50fa5abcdb30f9591a3d0f32dd56355R22
Related to #7270