Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Intermediate dApp Guide #7349

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

danforbes
Copy link
Contributor

Related to #7270

Copy link

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 642.3 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 622.77 kB 0%
../lib/commonjs/index.d.ts 8.72 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB 0%
../lib/commonjs/abi.d.ts 1.06 kB 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: a339ac5 Previous: 3687070 Ratio
processingTx 22802 ops/sec (±6.76%) 22856 ops/sec (±6.62%) 1.00
processingContractDeploy 40163 ops/sec (±7.66%) 37573 ops/sec (±8.57%) 0.94
processingContractMethodSend 16807 ops/sec (±7.21%) 15453 ops/sec (±7.92%) 0.92
processingContractMethodCall 28016 ops/sec (±7.30%) 27091 ops/sec (±7.83%) 0.97
abiEncode 44220 ops/sec (±7.58%) 42669 ops/sec (±7.08%) 0.96
abiDecode 31246 ops/sec (±6.60%) 30350 ops/sec (±6.23%) 0.97
sign 1556 ops/sec (±0.96%) 1520 ops/sec (±3.42%) 0.98
verify 368 ops/sec (±0.67%) 362 ops/sec (±0.69%) 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.50%. Comparing base (3687070) to head (a339ac5).
Report is 2 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7349   +/-   ##
=======================================
  Coverage   94.50%   94.50%           
=======================================
  Files         217      217           
  Lines        8487     8487           
  Branches     2343     2343           
=======================================
  Hits         8021     8021           
  Misses        466      466           
Flag Coverage Δ
UnitTests 94.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdevcs jdevcs changed the title Update Intermediate dApp Guide (EIP-6963 Types no Longer in Namespace) Update Intermediate dApp Guide Oct 23, 2024
@danforbes danforbes merged commit 70352cd into 4.x Oct 23, 2024
54 checks passed
@danforbes danforbes deleted the chore/docs/intermediate-dapp-providers branch October 23, 2024 18:06
MRLab12 pushed a commit to MRLab12/web3.js that referenced this pull request Oct 30, 2024
@luu-alex luu-alex mentioned this pull request Nov 6, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants