make decodeFunctionCall and decodeFunctionReturn available at web3-eth-abi
#7345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: dee0899 | Previous: 331aa9c | Ratio |
|---|---|---|---|
processingTx |
22833 ops/sec (±6.89%) |
20042 ops/sec (±7.50%) |
0.88 |
processingContractDeploy |
38862 ops/sec (±7.79%) |
38574 ops/sec (±5.63%) |
0.99 |
processingContractMethodSend |
16065 ops/sec (±7.11%) |
14751 ops/sec (±9.38%) |
0.92 |
processingContractMethodCall |
27330 ops/sec (±7.66%) |
28271 ops/sec (±6.08%) |
1.03 |
abiEncode |
43284 ops/sec (±7.45%) |
41366 ops/sec (±7.53%) |
0.96 |
abiDecode |
30760 ops/sec (±7.00%) |
28375 ops/sec (±8.41%) |
0.92 |
sign |
1513 ops/sec (±4.18%) |
1500 ops/sec (±1.06%) |
0.99 |
verify |
363 ops/sec (±0.54%) |
356 ops/sec (±0.80%) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7345 +/- ##
==========================================
+ Coverage 94.45% 94.50% +0.04%
==========================================
Files 217 217
Lines 8483 8487 +4
Branches 2343 2343
==========================================
+ Hits 8013 8021 +8
+ Misses 470 466 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
Muhammad-Altabba
changed the title
decodeMethodParams and decodeMethodReturn availlable at web3-eth-abidecodeMethodParams and decodeMethodReturn available at web3-eth-abi
| @@ -1026,7 +1023,7 @@ export class Contract<Abi extends ContractAbi> | |||
| `The ABI for the provided method signature ${methodSignature} was not found.`, | |||
| ); | |||
| } | |||
| return { ...decodeMethodParams(abi, data), __method__: jsonInterfaceMethodToString(abi) }; | |||
There was a problem hiding this comment.
the property __method__ is now returned by decodeMethodParams.
Muhammad-Altabba
requested review from
avkos,
jdevcs and
luu-alex
as code owners
Muhammad-Altabba
changed the title
decodeMethodParams and decodeMethodReturn available at web3-eth-abidecodeMethodParams and decodeMethodReturn available at web3-eth-abi
Muhammad-Altabba
changed the title
decodeMethodParams and decodeMethodReturn available at web3-eth-abidecodeFunctionCall and decodeFunctionReturn available at web3-eth-abi
avkos
approved these changes
Oct 22, 2024
jdevcs
reviewed
Oct 22, 2024
jdevcs
reviewed
Oct 22, 2024
jdevcs
reviewed
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4917
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.