-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nextjs problem #7216
Fix nextjs problem #7216
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 7cc4f35 | Previous: e746566 | Ratio |
---|---|---|---|
processingTx |
22875 ops/sec (±9.24% ) |
23728 ops/sec (±7.13% ) |
1.04 |
processingContractDeploy |
39175 ops/sec (±7.18% ) |
40637 ops/sec (±7.66% ) |
1.04 |
processingContractMethodSend |
17125 ops/sec (±7.03% ) |
16949 ops/sec (±7.02% ) |
0.99 |
processingContractMethodCall |
27837 ops/sec (±7.21% ) |
28367 ops/sec (±7.27% ) |
1.02 |
abiEncode |
44532 ops/sec (±6.78% ) |
46116 ops/sec (±6.72% ) |
1.04 |
abiDecode |
29923 ops/sec (±7.41% ) |
31091 ops/sec (±7.58% ) |
1.04 |
sign |
1546 ops/sec (±0.75% ) |
1587 ops/sec (±0.92% ) |
1.03 |
verify |
367 ops/sec (±0.66% ) |
372 ops/sec (±2.74% ) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7216 +/- ##
==========================================
+ Coverage 94.48% 94.50% +0.02%
==========================================
Files 216 216
Lines 8434 8429 -5
Branches 2317 2315 -2
==========================================
- Hits 7969 7966 -3
+ Misses 465 463 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.