4x tests updates #7162
4x tests updates #7162
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 1edaf85 | Previous: 61e9e06 | Ratio |
|---|---|---|---|
processingTx |
8871 ops/sec (±3.71%) |
8729 ops/sec (±4.67%) |
0.98 |
processingContractDeploy |
40419 ops/sec (±6.25%) |
37973 ops/sec (±6.91%) |
0.94 |
processingContractMethodSend |
16336 ops/sec (±8.26%) |
15996 ops/sec (±6.56%) |
0.98 |
processingContractMethodCall |
28172 ops/sec (±6.07%) |
27488 ops/sec (±6.50%) |
0.98 |
abiEncode |
43095 ops/sec (±6.91%) |
43224 ops/sec (±7.07%) |
1.00 |
abiDecode |
29485 ops/sec (±8.81%) |
29694 ops/sec (±7.87%) |
1.01 |
sign |
1531 ops/sec (±3.23%) |
1501 ops/sec (±3.13%) |
0.98 |
verify |
377 ops/sec (±0.58%) |
368 ops/sec (±0.51%) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7162 +/- ##
=======================================
Coverage 94.45% 94.46%
=======================================
Files 215 215
Lines 8391 8400 +9
Branches 2313 2318 +5
=======================================
+ Hits 7926 7935 +9
Misses 465 465
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -203,7 +203,7 @@ describe('defaults', () => { | |||
| expect(web3Eth.defaultBlock).toBe('earliest'); | |||
|
|
|||
| // set by create new instance | |||
| eth2 = new Web3Eth({ | |||
| const eth2 = new Web3Eth({ | |||
There was a problem hiding this comment.
using local instances so different tests dnt interfere each other's values , and locally close connection instead of closing on last instance at end and other instances dangling
| key === 'maxListenersWarningThreshold' ) | ||
| { | ||
| // additionally set in event emitter | ||
| this.setMaxListenerWarningThreshold(Number(options[key])); |
There was a problem hiding this comment.
bug fix: #5079 (comment)
jdevcs
requested review from
avkos,
luu-alex and
Muhammad-Altabba
as code owners
Description
#5079
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.