-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transaction receipt return type #7159
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 2d03be3 | Previous: 5ad7e5b | Ratio |
---|---|---|---|
processingTx |
8949 ops/sec (±4.08% ) |
9148 ops/sec (±3.95% ) |
1.02 |
processingContractDeploy |
40612 ops/sec (±6.40% ) |
39275 ops/sec (±7.28% ) |
0.97 |
processingContractMethodSend |
16691 ops/sec (±9.24% ) |
15230 ops/sec (±9.01% ) |
0.91 |
processingContractMethodCall |
28235 ops/sec (±6.13% ) |
26302 ops/sec (±8.43% ) |
0.93 |
abiEncode |
43685 ops/sec (±8.12% ) |
41324 ops/sec (±6.98% ) |
0.95 |
abiDecode |
29946 ops/sec (±7.64% ) |
30233 ops/sec (±6.38% ) |
1.01 |
sign |
1527 ops/sec (±1.19% ) |
1496 ops/sec (±3.87% ) |
0.98 |
verify |
366 ops/sec (±0.40% ) |
362 ops/sec (±0.73% ) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7159 +/- ##
=======================================
Coverage 94.46% 94.46%
=======================================
Files 215 215
Lines 8396 8396
Branches 2315 2315
=======================================
Hits 7931 7931
Misses 465 465
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description
#6372
Formatted types will always be returning type
Bytes
due to casting when it should return based on return formatPlease include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.