-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tx Types and ERC20 token transaction #7156
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: b7a848e | Previous: 9afaa61 | Ratio |
---|---|---|---|
processingTx |
9088 ops/sec (±3.54% ) |
9405 ops/sec (±3.55% ) |
1.03 |
processingContractDeploy |
36084 ops/sec (±8.12% ) |
40485 ops/sec (±7.27% ) |
1.12 |
processingContractMethodSend |
15510 ops/sec (±7.17% ) |
15979 ops/sec (±8.96% ) |
1.03 |
processingContractMethodCall |
27073 ops/sec (±7.14% ) |
28320 ops/sec (±6.00% ) |
1.05 |
abiEncode |
41898 ops/sec (±7.39% ) |
44820 ops/sec (±7.48% ) |
1.07 |
abiDecode |
29265 ops/sec (±8.13% ) |
30901 ops/sec (±8.03% ) |
1.06 |
sign |
1466 ops/sec (±3.57% ) |
1528 ops/sec (±3.66% ) |
1.04 |
verify |
367 ops/sec (±0.57% ) |
377 ops/sec (±0.59% ) |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7156 +/- ##
=======================================
Coverage 94.46% 94.46%
=======================================
Files 215 215
Lines 8396 8396
Branches 2315 2315
=======================================
Hits 7931 7931
Misses 465 465
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: Dan Forbes <[email protected]>
Co-authored-by: Dan Forbes <[email protected]>
Co-authored-by: Dan Forbes <[email protected]>
Co-authored-by: Dan Forbes <[email protected]>
Co-authored-by: Dan Forbes <[email protected]>
Co-authored-by: Dan Forbes <[email protected]>
Thank you @danforbes for the heads up w the typos!💪 |
|
||
## Transaction Type 2 (EIP-1559) | ||
|
||
When a user creates an EIP-1559 transaction, they specify the maximum fee they are willing to pay `maxFeePerGas` as well as a tip `maxPriorityFeePerGas` to incentivize the miner. The actual fee paid by the user is then determined by the network based on the current demand for block space and the priority of the transaction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very helpful! nice.
if you can also loop @danforbes into this that would be great. When he has free time would like to also have his opinion on this! |
nevermind, hes already commented :) |
Co-authored-by: Alex <[email protected]>
Co-authored-by: Alex <[email protected]>
Closes #5732