add test coverage to web3-core #7091
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 26e094f | Previous: b234c1c | Ratio |
|---|---|---|---|
processingTx |
9331 ops/sec (±4.08%) |
9042 ops/sec (±4.12%) |
0.97 |
processingContractDeploy |
40316 ops/sec (±6.79%) |
38054 ops/sec (±6.81%) |
0.94 |
processingContractMethodSend |
20073 ops/sec (±6.02%) |
18746 ops/sec (±7.29%) |
0.93 |
processingContractMethodCall |
40971 ops/sec (±4.85%) |
39055 ops/sec (±5.29%) |
0.95 |
abiEncode |
44978 ops/sec (±6.79%) |
43251 ops/sec (±6.96%) |
0.96 |
abiDecode |
30857 ops/sec (±7.36%) |
29622 ops/sec (±6.71%) |
0.96 |
sign |
1634 ops/sec (±0.78%) |
1542 ops/sec (±4.29%) |
0.94 |
verify |
366 ops/sec (±0.60%) |
363 ops/sec (±1.04%) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7091 +/- ##
==========================================
+ Coverage 93.98% 94.73% +0.74%
==========================================
Files 215 215
Lines 8335 8325 -10
Branches 2301 2295 -6
==========================================
+ Hits 7834 7887 +53
+ Misses 501 438 -63
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -438,15 +437,6 @@ export class Web3RequestManager< | |||
| throw new ResponseError(response, 'Got batch response for a normal request.'); | |||
| } | |||
|
|
|||
| if ( | |||
| (jsonRpc.isResponseWithError(response) || jsonRpc.isResponseWithResult(response)) && | |||
There was a problem hiding this comment.
removed, This conditional can never happen as we check jsonRpc.isResponseWithError(response) and jsonRpc.isResponseWithResult(response) seperately
| @@ -82,16 +81,6 @@ export abstract class Web3Subscription< | |||
| super(); | |||
| const { requestManager } = options as { requestManager: Web3RequestManager<API> }; | |||
| const { subscriptionManager } = options as { subscriptionManager: Web3SubscriptionManager }; | |||
| if (requestManager && subscriptionManager) { | |||
There was a problem hiding this comment.
removed, in the constructor
only one of requestManager or subscriptionManager must be defined
| 'Only requestManager or subscriptionManager should be provided at Subscription constructor', | ||
| ); | ||
| } | ||
| if (!requestManager && !subscriptionManager) { |
There was a problem hiding this comment.
removed, in the constructor
either requestManager or subscriptionManager must be defined
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
#7033
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.