-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SNYK for 4.x #7064
Fix SNYK for 4.x #7064
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 0a40c37 | Previous: 683be62 | Ratio |
---|---|---|---|
processingTx |
8975 ops/sec (±4.07% ) |
9323 ops/sec (±4.24% ) |
1.04 |
processingContractDeploy |
37713 ops/sec (±7.22% ) |
38254 ops/sec (±7.37% ) |
1.01 |
processingContractMethodSend |
17545 ops/sec (±8.03% ) |
19935 ops/sec (±6.23% ) |
1.14 |
processingContractMethodCall |
36725 ops/sec (±5.93% ) |
41139 ops/sec (±5.01% ) |
1.12 |
abiEncode |
41111 ops/sec (±7.26% ) |
43993 ops/sec (±8.04% ) |
1.07 |
abiDecode |
29634 ops/sec (±6.09% ) |
30862 ops/sec (±7.34% ) |
1.04 |
sign |
1543 ops/sec (±4.03% ) |
1600 ops/sec (±0.85% ) |
1.04 |
verify |
364 ops/sec (±0.55% ) |
379 ops/sec (±0.35% ) |
1.04 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7064 +/- ##
=======================================
Coverage 92.17% 92.17%
=======================================
Files 215 215
Lines 8335 8335
Branches 2301 2301
=======================================
Hits 7683 7683
Misses 652 652
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging for testing .snyk file
Description
Fixes #7017 for 4.x
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.