fix(docs): quickstart #7062
Merged
fix(docs): quickstart #7062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danforbes
requested review from
avkos,
jdevcs,
luu-alex and
Muhammad-Altabba
as code owners
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: dd720ee | Previous: 962b99f | Ratio |
|---|---|---|---|
processingTx |
9265 ops/sec (±3.69%) |
9347 ops/sec (±4.12%) |
1.01 |
processingContractDeploy |
40089 ops/sec (±6.63%) |
39267 ops/sec (±7.45%) |
0.98 |
processingContractMethodSend |
19209 ops/sec (±6.74%) |
20364 ops/sec (±6.85%) |
1.06 |
processingContractMethodCall |
39199 ops/sec (±5.07%) |
41222 ops/sec (±6.07%) |
1.05 |
abiEncode |
45955 ops/sec (±6.16%) |
46343 ops/sec (±6.97%) |
1.01 |
abiDecode |
29479 ops/sec (±7.68%) |
30832 ops/sec (±8.28%) |
1.05 |
sign |
1578 ops/sec (±0.87%) |
1603 ops/sec (±3.74%) |
1.02 |
verify |
371 ops/sec (±0.64%) |
380 ops/sec (±0.55%) |
1.02 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7062 +/- ##
==========================================
+ Coverage 87.37% 92.20% +4.82%
==========================================
Files 197 215 +18
Lines 7548 8334 +786
Branches 2059 2300 +241
==========================================
+ Hits 6595 7684 +1089
+ Misses 953 650 -303
Flags with carried forward coverage won't be shown. Click here to find out more.
|
danforbes
force-pushed
the
fix/docs/quickstart
branch
from
7ab4759
to
dd720ee
Compare
jdevcs
approved these changes
May 27, 2024
|
looks great , Thanks @danforbes |
avkos
approved these changes
May 27, 2024
This was referenced Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to doc's Quickstart section