-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow fromwei and toWei to accept numbers as units #7052
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 356cbb5 | Previous: 553f270 | Ratio |
---|---|---|---|
processingTx |
8879 ops/sec (±4.79% ) |
9223 ops/sec (±3.52% ) |
1.04 |
processingContractDeploy |
38280 ops/sec (±7.60% ) |
38080 ops/sec (±7.25% ) |
0.99 |
processingContractMethodSend |
18589 ops/sec (±6.86% ) |
19561 ops/sec (±4.97% ) |
1.05 |
processingContractMethodCall |
39152 ops/sec (±4.01% ) |
38511 ops/sec (±5.89% ) |
0.98 |
abiEncode |
42815 ops/sec (±7.28% ) |
43655 ops/sec (±6.63% ) |
1.02 |
abiDecode |
29994 ops/sec (±6.32% ) |
29655 ops/sec (±8.94% ) |
0.99 |
sign |
1530 ops/sec (±3.49% ) |
1555 ops/sec (±3.84% ) |
1.02 |
verify |
367 ops/sec (±0.58% ) |
371 ops/sec (±0.51% ) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7052 +/- ##
==========================================
- Coverage 91.98% 91.96% -0.02%
==========================================
Files 215 215
Lines 8296 8304 +8
Branches 2280 2284 +4
==========================================
+ Hits 7631 7637 +6
- Misses 665 667 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
throw new InvalidIntegerError(unit); | ||
} | ||
|
||
denomination = BigInt(10)**BigInt(unit); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this **
will cause an issue. More at: #6506
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.