Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow fromwei and toWei to accept numbers as units #7052

Merged
merged 3 commits into from
May 22, 2024

Conversation

luu-alex
Copy link
Contributor

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented May 21, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 624.48 kB → 624.93 kB (+467 B) +0.07%
Changeset
File Δ Size
../web3-errors/lib/commonjs/errors/utils_errors.js 📈 +317 B (+6.21%) 4.98 kB → 5.29 kB
../web3-utils/lib/commonjs/converters.js 📈 +532 B (+2.52%) 20.6 kB → 21.12 kB
../web3-errors/lib/commonjs/error_codes.js 📈 +66 B (+0.62%) 10.38 kB → 10.45 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 605.18 kB → 605.64 kB (+467 B) +0.08%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 356cbb5 Previous: 553f270 Ratio
processingTx 8879 ops/sec (±4.79%) 9223 ops/sec (±3.52%) 1.04
processingContractDeploy 38280 ops/sec (±7.60%) 38080 ops/sec (±7.25%) 0.99
processingContractMethodSend 18589 ops/sec (±6.86%) 19561 ops/sec (±4.97%) 1.05
processingContractMethodCall 39152 ops/sec (±4.01%) 38511 ops/sec (±5.89%) 0.98
abiEncode 42815 ops/sec (±7.28%) 43655 ops/sec (±6.63%) 1.02
abiDecode 29994 ops/sec (±6.32%) 29655 ops/sec (±8.94%) 0.99
sign 1530 ops/sec (±3.49%) 1555 ops/sec (±3.84%) 1.02
verify 367 ops/sec (±0.58%) 371 ops/sec (±0.51%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.96%. Comparing base (553f270) to head (c53a0a9).

Current head c53a0a9 differs from pull request most recent head 356cbb5

Please upload reports for the commit 356cbb5 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #7052      +/-   ##
==========================================
- Coverage   91.98%   91.96%   -0.02%     
==========================================
  Files         215      215              
  Lines        8296     8304       +8     
  Branches     2280     2284       +4     
==========================================
+ Hits         7631     7637       +6     
- Misses        665      667       +2     
Flag Coverage Δ
UnitTests 91.96% <85.71%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@luu-alex luu-alex marked this pull request as ready for review May 21, 2024 16:15
@luu-alex luu-alex merged commit 3904a46 into 4.x May 22, 2024
18 checks passed
@luu-alex luu-alex deleted the feat/AddNumbersupportWei branch May 22, 2024 03:35
throw new InvalidIntegerError(unit);
}

denomination = BigInt(10)**BigInt(unit);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this ** will cause an issue. More at: #6506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants