Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added troubleshooting example #7009

Merged
merged 2 commits into from
May 6, 2024
Merged

Added troubleshooting example #7009

merged 2 commits into from
May 6, 2024

Conversation

SantiagoDevRel
Copy link
Member

closes #6533

@Muhammad-Altabba pls check if this is what you have in mind for the troubleshooting page and feel free to request any changes💪🙌

Copy link

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 623.22 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 604.16 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.45 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: a1a801b Previous: 6c075db Ratio
processingTx 9168 ops/sec (±4.27%) 9301 ops/sec (±4.81%) 1.01
processingContractDeploy 40093 ops/sec (±6.53%) 39129 ops/sec (±7.62%) 0.98
processingContractMethodSend 18403 ops/sec (±7.82%) 19443 ops/sec (±5.19%) 1.06
processingContractMethodCall 38854 ops/sec (±5.38%) 38971 ops/sec (±6.34%) 1.00
abiEncode 43978 ops/sec (±6.48%) 44252 ops/sec (±6.92%) 1.01
abiDecode 29611 ops/sec (±7.20%) 30419 ops/sec (±8.89%) 1.03
sign 1564 ops/sec (±1.04%) 1656 ops/sec (±4.08%) 1.06
verify 374 ops/sec (±0.50%) 373 ops/sec (±0.78%) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
However, it could be also to split the Troubleshooting into a separate page since it may grow overtime.

@SantiagoDevRel
Copy link
Member Author

Looks great! However, it could be also to split the Troubleshooting into a separate page since it may grow overtime.

Sure! since we agreed in the call a few days ago, let's leave it like this for now, if it grows too much we will split it for sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a troubleshooting page in our documentation
2 participants