-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added troubleshooting example #7009
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: a1a801b | Previous: 6c075db | Ratio |
---|---|---|---|
processingTx |
9168 ops/sec (±4.27% ) |
9301 ops/sec (±4.81% ) |
1.01 |
processingContractDeploy |
40093 ops/sec (±6.53% ) |
39129 ops/sec (±7.62% ) |
0.98 |
processingContractMethodSend |
18403 ops/sec (±7.82% ) |
19443 ops/sec (±5.19% ) |
1.06 |
processingContractMethodCall |
38854 ops/sec (±5.38% ) |
38971 ops/sec (±6.34% ) |
1.00 |
abiEncode |
43978 ops/sec (±6.48% ) |
44252 ops/sec (±6.92% ) |
1.01 |
abiDecode |
29611 ops/sec (±7.20% ) |
30419 ops/sec (±8.89% ) |
1.03 |
sign |
1564 ops/sec (±1.04% ) |
1656 ops/sec (±4.08% ) |
1.06 |
verify |
374 ops/sec (±0.50% ) |
373 ops/sec (±0.78% ) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
However, it could be also to split the Troubleshooting into a separate page since it may grow overtime.
Sure! since we agreed in the call a few days ago, let's leave it like this for now, if it grows too much we will split it for sure |
closes #6533
@Muhammad-Altabba pls check if this is what you have in mind for the troubleshooting page and feel free to request any changes💪🙌