-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra changes to make possibility add eip4844 type as a plugin #7000
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 37a3d6e | Previous: 6c075db | Ratio |
---|---|---|---|
processingTx |
8965 ops/sec (±4.15% ) |
9301 ops/sec (±4.81% ) |
1.04 |
processingContractDeploy |
39824 ops/sec (±6.58% ) |
39129 ops/sec (±7.62% ) |
0.98 |
processingContractMethodSend |
18720 ops/sec (±8.14% ) |
19443 ops/sec (±5.19% ) |
1.04 |
processingContractMethodCall |
38867 ops/sec (±5.79% ) |
38971 ops/sec (±6.34% ) |
1.00 |
abiEncode |
42261 ops/sec (±7.42% ) |
44252 ops/sec (±6.92% ) |
1.05 |
abiDecode |
28468 ops/sec (±8.07% ) |
30419 ops/sec (±8.89% ) |
1.07 |
sign |
1581 ops/sec (±1.35% ) |
1656 ops/sec (±4.08% ) |
1.05 |
verify |
361 ops/sec (±0.76% ) |
373 ops/sec (±0.78% ) |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7000 +/- ##
==========================================
- Coverage 91.98% 91.97% -0.01%
==========================================
Files 215 215
Lines 8284 8289 +5
Branches 2273 2277 +4
==========================================
+ Hits 7620 7624 +4
- Misses 664 665 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Fixes #6986
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.