Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin guide 6840 draft #6941

Merged
merged 6 commits into from
Apr 23, 2024
Merged

Plugin guide 6840 draft #6941

merged 6 commits into from
Apr 23, 2024

Conversation

SantiagoDevRel
Copy link
Member

No description provided.

Copy link

github-actions bot commented Mar 26, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
0 → 10 0 B → 623.22 kB (+623.22 kB) -
View detailed bundle breakdown

Added

Asset File Size % Changed
web3.min.js 0 B → 604.16 kB (+604.16 kB) -
../lib/commonjs/index.d.ts 0 B → 8.69 kB (+8.69 kB) -
../lib/commonjs/accounts.d.ts 0 B → 3.89 kB (+3.89 kB) -
../lib/commonjs/types.d.ts 0 B → 2.45 kB (+2.45 kB) -
../lib/commonjs/web3.d.ts 0 B → 1.35 kB (+1.35 kB) -
../lib/commonjs/web3_eip6963.d.ts 0 B → 1.2 kB (+1.2 kB) -
../lib/commonjs/abi.d.ts 0 B → 999 B (+999 B) -
../lib/commonjs/eth.exports.d.ts 0 B → 280 B (+280 B) -
../lib/commonjs/providers.exports.d.ts 0 B → 183 B (+183 B) -
../lib/commonjs/version.d.ts 0 B → 60 B (+60 B) -

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

No assets were unchanged

Copy link

Benchmark

Benchmark suite Current: 253f911 Previous: 6c075db Ratio
processingTx 8901 ops/sec (±4.75%) 9301 ops/sec (±4.81%) 1.04
processingContractDeploy 37210 ops/sec (±5.82%) 39129 ops/sec (±7.62%) 1.05
processingContractMethodSend 18597 ops/sec (±7.32%) 19443 ops/sec (±5.19%) 1.05
processingContractMethodCall 37169 ops/sec (±6.43%) 38971 ops/sec (±6.34%) 1.05
abiEncode 42817 ops/sec (±6.72%) 44252 ops/sec (±6.92%) 1.03
abiDecode 29273 ops/sec (±7.89%) 30419 ops/sec (±8.89%) 1.04
sign 1571 ops/sec (±3.41%) 1656 ops/sec (±4.08%) 1.05
verify 370 ops/sec (±0.55%) 373 ops/sec (±0.78%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Merging #6941 (0882837) into 4.x (4358140) will increase coverage by 4.61%.
Report is 224 commits behind head on 4.x.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6941      +/-   ##
==========================================
+ Coverage   87.37%   91.98%   +4.61%     
==========================================
  Files         197      215      +18     
  Lines        7548     8284     +736     
  Branches     2059     2273     +214     
==========================================
+ Hits         6595     7620    +1025     
+ Misses        953      664     -289     
Flag Coverage Δ
UnitTests 91.98% <ø> (+4.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 0882837 Previous: 6c075db Ratio
processingTx 8811 ops/sec (±4.21%) 9301 ops/sec (±4.81%) 1.06
processingContractDeploy 38668 ops/sec (±7.64%) 39129 ops/sec (±7.62%) 1.01
processingContractMethodSend 19255 ops/sec (±6.81%) 19443 ops/sec (±5.19%) 1.01
processingContractMethodCall 40478 ops/sec (±5.95%) 38971 ops/sec (±6.34%) 0.96
abiEncode 44700 ops/sec (±7.07%) 44252 ops/sec (±6.92%) 0.99
abiDecode 30785 ops/sec (±7.96%) 30419 ops/sec (±8.89%) 0.99
sign 1558 ops/sec (±3.57%) 1656 ops/sec (±4.08%) 1.06
verify 365 ops/sec (±0.51%) 373 ops/sec (±0.78%) 1.02

This comment was automatically generated by workflow using github-action-benchmark.

@jdevcs
Copy link
Contributor

jdevcs commented Apr 22, 2024

This PR lgtm , only few changes suggested.

@SantiagoDevRel SantiagoDevRel merged commit 7be0060 into 4.x Apr 23, 2024
53 of 54 checks passed
@SantiagoDevRel SantiagoDevRel deleted the plugin-guide-6840 branch April 23, 2024 08:47
@SantiagoDevRel SantiagoDevRel mentioned this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants