-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create a new type Eip1193Compatible
#6407
create a new type Eip1193Compatible
#6407
Conversation
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6407 +/- ##
=======================================
Coverage 89.11% 89.11%
=======================================
Files 199 199
Lines 7723 7723
Branches 2128 2128
=======================================
Hits 6882 6882
Misses 841 841
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Deploying with Cloudflare Pages
|
…the-providers-does-not-comply-with-eip-1193
Eip1193FullyCompatible
Eip1193Compatible
Description
Fixes #6345 by allowing the user to get an instance of any Web3 Provider that has the returned value of
request
fully compatible with EIP-1193.Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.