-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format transaction.type
to hex. Add empty accessList
is tx.type === '0x1'
#5979
Conversation
Pull Request Test Coverage Report for Build 4585263643Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
transaction.type
to hex. Add empty accessList
is `tx.type === '0x1'transaction.type
to hex. Add empty accessList
is tx.type === '0x1'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, except tiny refactoring.
Co-authored-by: Junaid <[email protected]>
@jdevcs Merged, thank you |
CHANGELOG.md
Outdated
### Changed | ||
|
||
- `transaction.type` is now formatted to a hex string before being send to provider (#5979) | ||
- When sending a transaction, if `transaction.type === '0x1' && transaction.accessList === []`, then `transaction.accessList` is set to `[]` (#5979) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean
transaction.type === '0x1' && transaction.accessList is undefined
then transaction.accessList
is set to []
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated via this commit, thank you
Pull Request Test Coverage Report for Build 4600732589Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
transaction.type
is now formatted to a hex string before being sent to providertransaction.type === '0x1' && transaction.accessList === 'undefined'
, thentransaction.accessList
is set to[]
Added test cases for Steps to Reproduce examples from here. With these changes everything is formatted as expected, however, we do not throw an error for
tx.type
exceededing bounds of0x0
to0x7f
closes #4597