Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.7.5 #5255

Merged
merged 9 commits into from
Aug 1, 2022
Merged

Release 1.7.5 #5255

merged 9 commits into from
Aug 1, 2022

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Jul 15, 2022

1.7.5

Changed

Added

Fixed

Security

@render
Copy link

render bot commented Jul 15, 2022

@jdevcs
Copy link
Contributor Author

jdevcs commented Jul 15, 2022

As part of the RC process, following test installations are performed in other projects and running their tests to see if everything.

  • installs properly
  • builds
  • tests pass

(This list will be actively edited)

Project Desc Status
oz-test-helpers Test utils. Subset of their suite is web3 contracts
synthetix ~1000 units

@coveralls
Copy link

coveralls commented Jul 15, 2022

Pull Request Test Coverage Report for Build 2774978684

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.599%

Totals Coverage Status
Change from base Build 2697072063: 0.0%
Covered Lines: 3269
Relevant Lines: 4131

💛 - Coveralls

@jdevcs jdevcs added the Review Needed Maintainer(s) need to review label Jul 15, 2022
@ghost
Copy link

ghost commented Jul 16, 2022

@jdevcs Could you merge this PR #5228 prior to merging this PR? Since it fixes some bugs introduced by #5085, I think it is necessary.

@jdevcs jdevcs changed the title Release 1.7.5-rc.0 Release 1.7.5-rc.1 Jul 19, 2022
@jdevcs
Copy link
Contributor Author

jdevcs commented Jul 19, 2022

@jdevcs Could you merge this PR #5228 prior to merging this PR? Since it fixes some bugs introduced by #5085, I think it is necessary.

Thanks , we discussed in team and its imp to include PR #5228 in 1.7.5 due to following fix:
(#5235)

@jdevcs
Copy link
Contributor Author

jdevcs commented Jul 19, 2022

For RC 1.7.5-rc.1:
As part of the RC process, following test installations are performed in other projects and running their tests to see if everything.

  • installs properly
  • builds
  • tests pass

(This list will be actively edited)

Project Desc Status
oz-test-helpers Test utils. Subset of their suite is web3 contracts x
synthetix ~1000 units

@jdevcs jdevcs marked this pull request as ready for review July 25, 2022 18:42
@luu-alex
Copy link
Contributor

Synthetix tests and oz tests passed ✅ for 1.7.5-rc.1

@jdevcs
Copy link
Contributor Author

jdevcs commented Aug 1, 2022

oz two tests are failing:

1) expectRevert
       assertion
         rejects an outOfGas:
     AssertionError: expect.fail()
      at assertFailure (test/helpers/assertFailure.js:9:10)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at Context.<anonymous> (test/src/expectRevert.test.js:123:7)

  2) expectRevert
       outOfGas
         accepts an outOfGas:

      Wrong kind of exception received
      + expected - actual

      -Transaction: 0x4e501c63fc4b9d533635216abf480158732cd842f20efd89335781fd1d0868e2 exited with an error (status 0) after consuming all gas.
      -     Please check that the transaction:
      -     - satisfies all conditions set by Solidity `assert` statements.
      -     - has enough gas to execute the full transaction.
      -     - does not trigger an invalid opcode by other means (ex: accessing an array out of bounds).
      +out of gas
      
      at expectException (src/expectRevert.js:20:30)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)
      at Context.<anonymous> (test/src/expectRevert.test.js:153:7)

discussed in team: oz two tests not passing ( for current RC also for couple of past releases ), we can ignore this test.

@jdevcs jdevcs removed the Review Needed Maintainer(s) need to review label Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants