Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[README] Add GitPOAP Badge to Display Number of Minted GitPOAPs for Contributors #5234

Merged
merged 3 commits into from
Aug 17, 2022

Conversation

burz
Copy link

@burz burz commented Jul 12, 2022

Description

Hey all, this PR adds a GitPOAP Badge to the README that displays the number of minted GitPOAPs for this repository by contributors to this repo.

You can see an example of this in our Documentation repository.

This should help would-be contributors as well as existing contributors find out that they will/have received GitPOAPs for their contributions.

CC: @colfax23 @kayla-henrie

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

Question: I would assume CHANGELOG.md would not need to be updated for this small README change? I will update the PR if I should still go ahead with it. Thanks!

@jdevcs jdevcs added 1.x 1.0 related issues Documentation Relates to project wiki or documentation Future Release For future release. labels Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Documentation Relates to project wiki or documentation Future Release For future release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants