Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc example for web3.eth.personal (#4397) #4409

Merged
merged 7 commits into from
Oct 5, 2021
Merged

Update doc example for web3.eth.personal (#4397) #4409

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ccc3074
doc: fix example in web3.eth.personal (#4397)
robertu7 Sep 30, 2021
ac9ec3a
Update CHANGELOG
spacesailor24 Sep 30, 2021
5bafc89
Merge branch 'wyatt/1.x/4397-doc-fix' of github.com:ChainSafe/web3.js…
spacesailor24 Sep 30, 2021
faffe91
Merge branch '1.x' into wyatt/1.x/4397-doc-fix
spacesailor24 Sep 30, 2021
fd2d4a7
Merge branch '1.x' into wyatt/1.x/4397-doc-fix
spacesailor24 Sep 30, 2021
89d23e4
Merge branch '1.x' into wyatt/1.x/4397-doc-fix
spacesailor24 Oct 5, 2021
fc69576
Merge branch '1.x' into wyatt/1.x/4397-doc-fix
spacesailor24 Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,11 +444,9 @@ Released with 1.0.0-beta.37 code base.
- ethers from 5.1.4 to 5.4.4 (#4231)
- karma from 5.2.3 to 6.3.4 (#4231)
- lerna from 3.22.1 to 4.0.0 (#4231)
- Dropped build tests in CI for Node v8 and v10, and added support for Node v14
- Dropped build tests in CI for Node v8 and v10, and added support for Node v14 (#4231)
- Change default value for `maxPriorityFeePerGas` from `1 Gwei` to `2.5 Gwei` (#4284)
- Introduced new configuration "blockHeaderTimeout" for waiting of block headers for transaction receipt (#3891)
- Fixed bug in signTransaction (#4295)
- Format `block.baseFeePerGas` to number (#4330)

## [Unreleased]

Expand All @@ -465,3 +463,7 @@ Released with 1.0.0-beta.37 code base.
- Not considering `tx.chainId` if `tx.common.customChain.chainId` is provided for `web3.eth.accounts.signTransaction` function (#4293)
- Added missing PromiEvent handler types (#4194)
- Updated README to include Webpack 5 angular support instructions (#4174)
- Emit subscription id with connect event when creating a subscription (#4300)
- Introduced new configuration "blockHeaderTimeout" for waiting of block headers for transaction receipt (#3891)
- Format `block.baseFeePerGas` to number (#4330)
- Correct `web3-eth-personal.sendTransaction` example in documentation (#4409)
2 changes: 1 addition & 1 deletion docs/web3-eth-personal.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ Example

.. code-block:: javascript

web3.eth.sendTransaction({
web3.eth.personal.sendTransaction({
from: "0xEB014f8c8B418Db6b45774c326A0E64C78914dC0",
gasPrice: "20000000000",
gas: "21000",
Expand Down