Custom TransactionSigner and eth-account module improvements.

docs/web3-eth.rst

@@ -1174,7 +1174,8 @@ signTransaction
 
     web3.eth.signTransaction(transactionObject [, address] [, callback])
 
-Signs a transaction. This account needs to be unlocked.
+The method ``signTransaction`` signs a transaction with the private key of the given address.
+This method does only work if you're connected to a Parity node.
 
 ----------
 Parameters

packages/web3-core-method/lib/factories/AbstractMethodFactory.js

@@ -20,6 +20,10 @@
  * @date 2018
  */
 
+import SendRawTransactionMethod from '../../src/methods/transaction/SendRawTransactionMethod';
+import GetTransactionCountMethod from '../../src/methods/account/GetTransactionCountMethod';
+import ChainIdMethod from '../../src/methods/network/ChainIdMethod';
+
 export default class AbstractMethodFactory {
     /**
      * @param {MethodModuleFactory} methodModuleFactory
@@ -89,25 +93,18 @@ export default class AbstractMethodFactory {
         /* eslint-disable new-cap */
         switch (method.Type) {
             case 'CALL':
-                if (method.name === 'SignMethod') {
-                    return new method(
-                        this.utils,
-                        this.formatters,
-                        this.methodModuleFactory.accounts,
-                        this.methodModuleFactory.createMessageSigner()
-                    );
-                }
-
                 return new method(this.utils, this.formatters);
             case 'SEND':
                 if (method.name === 'SendTransactionMethod') {
+                    const transactionConfirmationWorkflow = this.methodModuleFactory.createTransactionConfirmationWorkflow();
+
                     return new method(
                         this.utils,
                         this.formatters,
-                        this.methodModuleFactory.createTransactionConfirmationWorkflow(),
-                        this.methodModuleFactory.accounts,
-                        this.methodModuleFactory.createTransactionSigner(),
-                        this.methodModuleFactory.createSendRawTransactionMethod()
+                        transactionConfirmationWorkflow,
+                        new SendRawTransactionMethod(this.utils, this.formatters, transactionConfirmationWorkflow),
+                        new ChainIdMethod(this.utils, this.formatters),
+                        new GetTransactionCountMethod(this.utils, this.formatters)
                     );
                 }
 

packages/web3-core-method/lib/methods/AbstractMethod.js

@@ -214,15 +214,4 @@ export default class AbstractMethod {
     isHash(parameter) {
         return isString(parameter) && parameter.indexOf('0x') === 0;
     }
-
-    /**
-     * Checks if accounts is defined and if wallet is not empty
-     *
-     * @method hasWallet
-     *
-     * @returns {Boolean}
-     */
-    hasWallets() {
-        return this.accounts && this.accounts.wallet.length > 0;
-    }
 }