Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type of Web3Eth.calculateFeeData Param baseFeePerGasFactor Should Support Decimals #7321

Closed
danforbes opened this issue Oct 11, 2024 · 2 comments · Fixed by #7332
Closed

Type of Web3Eth.calculateFeeData Param baseFeePerGasFactor Should Support Decimals #7321

danforbes opened this issue Oct 11, 2024 · 2 comments · Fixed by #7332
Labels
4.x 4.0 related Bug Addressing a bug Good First Issue Great to learn the internals of web3.js

Comments

@danforbes
Copy link
Contributor

When specifying the baseFeePerGasFactor for the Web3Eth.calculcateFeeData method, users may wish to specify a percentage, such as %112.5. To support this, the type of this parameter should be changed from bigint to a type that supports decimal values.
@mconnelly8 mconnelly8 added Bug Addressing a bug 4.x 4.0 related labels Oct 14, 2024
@TemirlanBasitov
Copy link
Contributor

TemirlanBasitov commented Oct 16, 2024 •
edited
Loading

you can use baseFeePerGasFactor: number = 2, instead of bigint(2)

@TemirlanBasitov
Copy link
Contributor

#7332

@danforbes danforbes linked a pull request Oct 28, 2024 that will close this issue
allowing to specify percentage-based factors (like 1.125 for 112.5%) #7332
Merged
17 tasks
@mconnelly8 mconnelly8 added the Good First Issue Great to learn the internals of web3.js label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.x 4.0 related Bug Addressing a bug Good First Issue Great to learn the internals of web3.js
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allowing to specify percentage-based factors (like 1.125 for 112.5%) TemirlanBasitov/web3.js
4 participants
@danforbes @TemirlanBasitov @mconnelly8 and others