Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web3-eth-contract tests update/fixes #7231

Closed
mconnelly8 opened this issue Sep 3, 2024 · 2 comments · Fixed by #7338
Closed

Web3-eth-contract tests update/fixes #7231

mconnelly8 opened this issue Sep 3, 2024 · 2 comments · Fixed by #7338
Assignees
Labels
4.x 4.0 related Bug Addressing a bug Investigate

Comments

@mconnelly8
Copy link

--forceExit flag should be removed from the web3-eth-contract tests
test:integration

@mconnelly8 mconnelly8 added Bug Addressing a bug Investigate labels Sep 3, 2024
@mconnelly8 mconnelly8 added the 4.x 4.0 related label Oct 1, 2024
@krzysu krzysu self-assigned this Oct 9, 2024
@krzysu
Copy link
Contributor

krzysu commented Oct 15, 2024

I’m trying to understand the reasoning behind this issue. As I see it, the --forceExit flag is used in tests that rely on a WebSocket provider because the test runner doesn’t exit properly due to hanging socket connections. This could potentially be solved by closing the connection correctly with web3.currentProvider.disconnect().

In the web3-eth-contract package, the integration tests are run by default using the HTTP provider. However, some tests are conditional and only execute with a WebSocket provider. When using the HTTP provider, you’ll notice that 15 tests are skipped.

I’m looking for more context to understand whether I should focus on enabling the WebSocket tests, ensuring proper connection closure, or if there’s a larger issue that I’m missing. Could you please clarify the intended approach?

@jdevcs
Copy link
Contributor

jdevcs commented Oct 15, 2024

related PR: #7162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related Bug Addressing a bug Investigate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants