Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When formatting a transaction in 4.x, it it not more set to null if not provided or invalid #6332

Open
Muhammad-Altabba opened this issue Aug 3, 2023 · 1 comment
Labels
4.x 4.0 related

Comments

@Muhammad-Altabba
Copy link
Contributor

Muhammad-Altabba commented Aug 3, 2023

When formatting a transaction in 1.x it used to be set to null if it was not provided or was not a valid address (being 0x for example), but in 4.x it is kept as undefined if it was not provided.

tx.to = null; // set to `null` if invalid address

This is a breaking change that was not documented.

Do we like to keep this change, and document it? Or to keep the old behavior?

Hint: This breaking change required the following changes in this commit, for example: handle when tx.to is undefined instead of null

@Muhammad-Altabba Muhammad-Altabba added the 4.x 4.0 related label Aug 3, 2023
@mconnelly8
Copy link

We will keep this and update the documentation for the edge case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related
Projects
None yet
Development

No branches or pull requests

2 participants